]> dgit.raspbian.org Git - gnome-shell.git/commit
viewSelector: don't process key presses from capture-event
authorDan Winship <danw@gnome.org>
Wed, 16 Feb 2011 18:27:05 +0000 (13:27 -0500)
committerDan Winship <danw@gnome.org>
Thu, 24 Feb 2011 14:36:36 +0000 (09:36 -0500)
commitd5735496afad0f81e8124387fa0ea99fb6586732
tree01d26faa4051cdc3e56686e0e922178fd707c88c
parent3755783d41057ae69efc03957fb17430411bb1a2
viewSelector: don't process key presses from capture-event

Rather than connecting to stage::capture-event and then trying to
guess whether or not a given key-press should be handled by us or not,
handle the end-search-on-Escape case from entry::key-press-event
(since it only makes sense when the entry is focused anyway) and the
start-search-on-printable-key case from stage::key-press-event (which
will only get the events that no other actor wanted for itself).

Similarly, do exit-overview-on-Escape and switch-panes cases from
stage::key-press-event, rather than
viewSelector.actor::key-press-event, so that they will work correctly
even if the keyboard focus is somewhere else. (Also fix a longstanding
bug in the pane-switching code, which was supposed to be disabled when
a search was active, but was checking a non-existent variable.)

https://bugzilla.gnome.org/show_bug.cgi?id=642502
js/ui/overview.js
js/ui/viewSelector.js